microsoft / microsoft/durabletask-mssql
Payloads as varchar and charset of payloads
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 105
- Forks
- 36
- PR merge metrics
- No merged PRs in 30d
Description
The choice of using varchar(max) instead of nvarchar(max) for payloads causes issues when payloads contain characters not supported by varchar.
The workaround would be to encode every message, but that is a solution more adapted for new apps, and even then, it's a bit awkward.
Migrating existing apps could really be problematic.
For example, I added an emoji to an activity output. Note the '??' that have replaced it. When using Azure Storage, there is no issue with charset.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing where payloads are stored in the MSSQL schema and how existing applications are migrated; the issue specifically contrasts varchar(max) with nvarchar(max). Reproduce the reported emoji corruption and verify that new and migrated payloads preserve characters unsupported by varchar without requiring per-message encoding.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp, sql
- Domain
- database
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100