microsoft / microsoft/demikernel

[inetstack] Not all packets from push batch are being added to unsent queue

Open
#1,625 0 comments 0 reactions 1 assignee View on GitHub

@iyzhang is already working on this.

Since Sep 25, 2025.

bug
Dominant language
Rust
Stars
1.2k
Forks
151
PR merge metrics
No merged PRs in 30d

Description

Description

If the send window closes during a batch send, we stop adding packets to the unsent queue. Since we are still incrementing the unsent sequence number, those packets are effectively lost.

How to Reproduce

Steps to reproduce the behavior:

  1. Send enough packets in a batch to fill the send window
  2. After receiving some acks, we should send all of the unsent packets.
  3. Instead we send one packet and drop the others.

Expected Behavior

We should buffer unsent packets until the send window opens and then reliably send all of the unsent packets.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.