microsoft / microsoft/debug-adapter-protocol

Disabled breakpoints are erased from breakpoints list when sending a Breakpoint Request

Open
#560 6 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

info-needed
Dominant language
HTML
Stars
1.8k
Forks
173
Avg merge
7d 7h
Merged PRs (30d)
2

Description

We are implementing a debug adapter extension. While implementing breakpoint features, we found out there is no distinction between enabling/disabling breakpoints and adding/removing them when they are being sent through a setBreakpointRequest. In other words, whenever a breakpoint is disabled, this breakpoint is removed from the breakpoint list being sent via the setBreakpointRequest.

This causes an inconsistency, between what is viewed in the Breakpoints Window in VS Code and what is happening in the backend.

To resolve this issue, we would probably need the stored breakpoint list to use some attribute in the breakpoint type when enabling/disabling it rather than adding/removing the breakpoint altogether.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.