microsoft / microsoft/debug-adapter-protocol

DataBreakpointEvent?

Open
#30 3 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature-request
Dominant language
HTML
Stars
1.8k
Forks
173
Avg merge
7d 7h
Merged PRs (30d)
2

Description

I might be missing something here, but the Breakpoint type is for »Information about a Breakpoint created in setBreakpoints or setFunctionBreakpoints« while DataBreakpoint is for »Properties of a data breakpoint passed to the setDataBreakpoints request« and the BreakpointEvent is only for Breakpoint breakpoints. So it does not make sense to use BreakpointEvent for a change in a DataBreakpoint.

There is no DataBreakpointEvent. Is that an accidental omission?

I might want to create a data breakpoint based on a launch.json configuration option and inform vscode about it, so users can disable the breakpoint if they so choose (or for that matter, users might configure data breakpoints through the debug console instead of the vscode ui, and then I might also want to surface such breakpoints through vscode anyways).

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the protocol definitions for Breakpoint, DataBreakpoint, and BreakpointEvent, along with the setDataBreakpoints request described in the issue. Determine whether data-breakpoint changes require a distinct event and what clients must receive; done means the protocol behavior and any DataBreakpointEvent addition are clearly specified.

Written by the indexing model from the issue text.

Assessment

Tech stack
vscode
Domain
devtools
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.