microsoft / microsoft/debug-adapter-protocol
Continue request shouldn't fall back on continuing all threads, when a single thread can't be continued
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 1.8k
- Forks
- 173
- Avg merge
- 7d 7h
- Merged PRs (30d)
- 2
Description
"Continue" currently says that if it can't continue just one thread, it should continue all threads.
The protocol shouldn't specify a fallback on different behavior - instead the continue request should fail, while a continue request without a threadID should mean "continue all threads".
@weinand:
I agree that the fallback semantics is a bad idea. Please file DAP protocol bug for this.
But please note that it might be impossible to fix this in the current version of the DAP in a non-breaking way.
cc
@mostafaeweda
@ebluestein
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Continue request definition in the DAP protocol specification and review how threadID absence and an uncontinuable thread are currently specified. Confirm whether changing the fallback behavior would be breaking in the current DAP version; done means the specification has an agreed failure semantic and its compatibility implications are addressed.
Written by the indexing model from the issue text.
Assessment
- Domain
- api, backend-api-design
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100