microsoft / microsoft/debug-adapter-protocol
Add allThreadsContinued to responses that resume execution
Nobody has claimed this yet.
- Dominant language
- HTML
- Stars
- 1.8k
- Forks
- 173
- Avg merge
- 7d 7h
- Merged PRs (30d)
- 2
Description
In Go restarting one thread (aka goroutine) restarts them all. This is true for any resuming command: continue, next, stepOut, etc. When continuing we can set allThreadsContinued in ContinueResponse. But when a request is made for next, stepIn, etc, we must supplement each response with a ContinuedEvent with allThreadsContinued enabled (https://github.com/go-delve/delve/pull/2480). It would be better if the responses themselves had this field.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Review the ContinueResponse and ContinuedEvent definitions first, then trace the response definitions for continue, next, stepIn, and stepOut. Done means each command that resumes execution exposes allThreadsContinued on its response, rather than relying on a separate ContinuedEvent.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100