Make shutdown signal configurable
Open
@danegsta is already working on this.
Since Jul 21, 2023.
enhancement
- Dominant language
- Go
- Stars
- 190
- Forks
- 24
- Avg merge
- 2d 16h
- Merged PRs (30d)
- 18
Description
Currently a set of common signals (SIGTERM, SIGQUIT) is sent to attempt graceful shutdown of processes started by the controllers, however not all processes will honor all signals (or the behavior for a given signal may not match standard conventions). Rather than hardcoding a set list, we could allow a user to configure a shutdown signal and attempt to use that, defaulting to the standard SIGKILL if a signal isn't defined (or if they fail to respond to the configured shtudown signal in a sufficient period of time).
This would potentially allow us to simplify a lot of our shutdown logic.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.