microsoft / microsoft/copilot-for-eclipse
BYOK models with toolCalling=false still appear in Ask mode model picker
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 126
- Forks
- 60
- Avg merge
- 2d 6h
- Merged PRs (30d)
- 5
Description
Problem
Currently in Eclipse Copilot, when a user adds a custom BYOK model with Support Tool Calling unchecked (i.e. oolCalling=false), the model still appears in the model picker under Ask mode.
In VS Code, such models do not appear in the model picker under any mode (including Ask), because Ask mode now also supports and relies on tool calling.
Current Behavior (Eclipse)
toolCalling=falseBYOK model → hasCHAT_PANELscope only (noAGENT_PANEL)- Ask mode maps to
chat-panelscope → model appears in Ask model picker - Agent/Plan mode maps to
agent-panelscope → model does not appear
Expected Behavior
Since Ask mode now also uses tool calling, a BYOK model with toolCalling=false should arguably not appear in any mode's model picker — matching VS Code's behavior.
Key Code Paths
- ModelUtils.java (
com.microsoft.copilot.eclipse.ui.utils): assignsCHAT_PANELscope to all BYOK models, and only addsAGENT_PANELwhentoolCalling=true - ModelService.java: filters models by scope based on current chat mode (Ask →
chat-panel, Agent →agent-panel) - AddByokModelDialog.java: builds the BYOK model with capabilities from user input
Discussion Points
- Should we filter out
toolCalling=falseBYOK models from all modes (including Ask)? - Or should we keep them visible in Ask but clearly indicate they have limited capability?
- Need to align with VS Code's latest behavior for consistency across editors.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with ModelUtils.java, ModelService.java, and AddByokModelDialog.java to trace BYOK capabilities and scope filtering for Ask, Agent, and Plan modes. Compare the current Eclipse behavior with the VS Code behavior described in the issue, then confirm the chosen visibility rule and verify that the model picker reflects it consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- desktop, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100