microsoft / microsoft/component-detection
Add `FluentAssertions.Analyzers` and fix all warnings
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 553
- Forks
- 135
- Avg merge
- 20h 58m
- Merged PRs (30d)
- 6
Description
FluentAssertions.Analyzers is a Roslyn analyzer for FluentAssertions. It's based on the FluentAssertions tips. Adding it to Component Detection, and fixing all of the warnings it gives will make sure we use best practices when writing test assertions.
In order to do this in a step-by-step way, FluentAssertions.Analyzers should be added to each test project individually, before being added to the test directory Directory.Build.props
-
Microsoft.ComponentDetection.Common.Tests- #694
-
Microsoft.ComponentDetection.Contracts.Tests- #634
-
Microsoft.ComponentDetection.Detectors.Tests- #879
-
Microsoft.ComponentDetection.Orchestrator.Tests- #634
-
Microsoft.ComponentDetection.VerificationTests
AB#2088661
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the Microsoft.ComponentDetection.VerificationTests project and inspect test/Directory.Build.props, using the completed checklist items as context for the intended setup. Add FluentAssertions.Analyzers to this remaining test project, run its tests or build to identify warnings, and finish when the analyzer warnings are resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- build-system, testing-qa
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100