microsoft / microsoft/component-detection

Nuget "project centric detector" should not filter out dependencies

Open
#502 1 comment 0 reactions 1 assignee Assigned to @grvillic View on GitHub
breaking change detector:nuget status:requirements type:bug
Dominant language
C#
Stars
553
Forks
135
Avg merge
20h 58m
Merged PRs (30d)
6

Description

The project-centric detector filters out [a large list of dependencies by name](https://github.com/microsoft/component-detection/blob/9a5fff2af0b0d0ccbd813433d1696bbed27929bc/src/Microsoft.ComponentDetection.Detectors/nuget/NuGetProjectModelProjectCentricComponentDetector.cs#L31-L185).

I think this should not be done because this filters out dependencies which have security advisories filed against them. For example, `System.Text.RegularExpressions` is filtered out, but has a High severity alert against it (https://github.com/advisories/GHSA-cmhx-cq75-c4mj) which is detected by `dotnet list --vulnerable`.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.