microsoft / microsoft/cask

<provider-kind> name in CaskSecret is inconsistent with GenerateKey

Open
#75 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C#
Stars
6
Forks
6
Avg merge
8d 10h
Merged PRs (30d)
4

Description

docs/CaskSecret.md defines the field <provider-kind>:

https://github.com/microsoft/cask/blob/6f4c27277bdbe447929dba1a7f009bdddc0e9c0e/docs/CaskSecret.md?plain=1#L45

The <provider-kind> name is inconsistent with "Provider key kind" in GenerateKey Pseudo-Code:

https://github.com/microsoft/cask/blob/6f4c27277bdbe447929dba1a7f009bdddc0e9c0e/docs/GenerateKeyPseudoCode.md?plain=1#L18

and with the char providerKeyKind parameter in the Cask.GenerateKey API:

https://github.com/microsoft/cask/blob/6f4c27277bdbe447929dba1a7f009bdddc0e9c0e/src/Cask/Cask.cs#L236-L239

I suggest renaming it to <provider-key-kind>. That name will also make it clearer that the same provider can define several different values for this field.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the definition in docs/CaskSecret.md and compare it with the Provider key kind wording in docs/GenerateKeyPseudoCode.md and the providerKeyKind parameter in src/Cask/Cask.cs. Rename the CaskSecret field consistently to and verify that the referenced terminology matches across these files.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.