microsoft / microsoft/calculator
[RS5+] Update NavigationView to use DataTemplates and a template selector to generate menu in XAML rather than in code
Open
Nobody has claimed this yet.
approved
codebase quality
help wanted
Pri: 2
- Dominant language
- C#
- Stars
- 31.1k
- Forks
- 5.8k
- PR merge metrics
- No merged PRs in 30d
Description
Once our min version is RS5, we can update our app to use DataTemplates in the NavigationView. Downlevel, this is bugged and a DataTemplate with a NavigationViewItem/NavigationViewItemHeader as the top-level element will result in a double-nested item container.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file or test is named. Locate the current NavigationView menu generation, then read the surrounding XAML and code to understand the existing item structure; done means the menu uses DataTemplates and a template selector in XAML once RS5 is the minimum version, without the downlevel double-nesting problem.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- desktop, frontend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100