microsoft / microsoft/calculator
Update Calculator engine’s use of smart pointers
Open
Nobody has claimed this yet.
approved
codebase quality
help wanted
Pri: 2
- Dominant language
- C#
- Stars
- 31.1k
- Forks
- 5.8k
- PR merge metrics
- No merged PRs in 30d
Description
The Calculator engine allocates and frees its own memory which leads to issues such as double-frees that are hard to investigate. We should clean this code and switch to modern constructs such as smart_ptrs to eliminate these issues.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the Calculator engine's memory-allocation and freeing code; the issue names no files or tests. Trace the ownership paths and existing failure coverage, then consider the work complete when manual ownership no longer permits the reported double-free issues and relevant tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100