microsoft / microsoft/calculator
Calculator should not use FrameworkElement.Tag as it can be easily overwritten by internal control logic.
Open
Nobody has claimed this yet.
approved
codebase quality
help wanted
Pri: 3
- Dominant language
- C#
- Stars
- 31.1k
- Forks
- 5.8k
- PR merge metrics
- No merged PRs in 30d
Description
The use of the Tag property is bad practice and we should clean up the buttons that still use it. Tag is currently used for:
- Hamburger Button (fixed by move to NavigationView)
- About Button (fixed by move to NavigationView)
- OpenParenthesis buttons
- Programmer mode radix buttons (BIN/OCT/DEC/HEX)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the OpenParenthesis buttons and the Programmer mode radix buttons (BIN/OCT/DEC/HEX), which the issue identifies as remaining Tag users. Check how their current Tag values are consumed and verify that the cleanup preserves each button's behavior. Done means these controls no longer rely on FrameworkElement.Tag; the Hamburger and About buttons are already noted as fixed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100