microsoft / microsoft/boll

NodeModulesReferenceDetector is too aggressive...

Open
#41 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
TypeScript
Stars
20
Forks
9
PR merge metrics
No merged PRs in 30d

Description

Many webpack.config.js module.rules loader configurations would have an explicit excludes of a /node_modules/ pattern. We should allow these kinds of references. I think maybe we should only have the detector deal with things inside a require() or import statement. This will make the rule not catch 100% of stuff, but it can at least allow the proper uses of these node_modules appearances. Alternative is to have disable-single-line kind of thing so that we don't have to disable the entire rule altogether.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the NodeModulesReferenceDetector entry point and compare its handling of webpack.config.js loader rules with references inside require() or import statements. Review the alternative of allowing a single-line disable, then choose the supported behavior with maintainers. Done means valid /node_modules/ exclusions are no longer reported without broadly hiding genuine references.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js, typescript
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.