Running bump in monorepo using pnpm clears node_modules

Open
#955 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
node.js, typescript
Domain
build-system, release

Research direction

Start with the bump and publish command entry points and the changes from #942, then compare Beachball’s execa invocation with the reported pnpm install --lockfile-only --ignore-scripts terminal command. Reproduce the version-bump case and trace when the root node_modules is removed; done means bump or publish preserves it consistently with the direct pnpm command.

Written by the indexing model from the issue text.

Description

bug needs repro

When using the bump or publish command my node_modules (of the root workspace) are always cleared since the changes in #942.

When running the same command pnpm install --lockfile-only --ignore-scripts in my terminal if the package versions have been bumped, the node_modules are not removed.

I have checked the codebase of execa (package used to call pnpm) and in the pnpm codebase. But I can't seem to find any reason why it deletes the node_modules when running through beachball and why they are not deleted when running the pnpm command myself.

Dominant language
TypeScript
Stars
815
Forks
93
Avg merge
2d 13h
Merged PRs (30d)
12

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from microsoft/beachball

All issues in microsoft/beachball

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.