microsoft / microsoft/beachball
Beachball fails to find change files when run from non-gitroot
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 815
- Forks
- 93
- Avg merge
- 2d 13h
- Merged PRs (30d)
- 12
Description
If you run beachball publish from a location other than the root of the git repo, beachball fails to find the change files and reports Invalid change file change/foo.
The issue appears to be that getChangedPackages assumes that the paths returned by getAllChangedPackages are relative to cwd, whereas I think they are relative to gitroot.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting getChangedPackages and getAllChangedPackages, then reproduce beachball publish from a directory other than the Git repository root. Trace how each function resolves change-file paths; done means publishing from a non-root location finds the change files instead of reporting Invalid change file.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- git, typescript
- Domain
- release, tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100