microsoft / microsoft/azurechat
Template deployment fails on KeyVault naming
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 1.4k
- Forks
- 1.3k
- Avg merge
- 1d 11h
- Merged PRs (30d)
- 1
Description
Under certain scenarios, the template deployment fails because the KeyVault cannot have a double-hyphen ("--") in its name. This appears to be due to truncation of the "name" parameter entered by the user and combined on line 273 of infra/main.json:
273: "keyVaultName": "[toLower(format('{0}-kv-{1}', variables('kv_prefix'), parameters('resourceToken')))]",
removing the hyphens on either side of kv fixes the issue.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in infra/main.json at line 273 and inspect how the user-provided name is combined into keyVaultName. Reproduce a deployment with a name that triggers truncation, then verify the template deploys successfully without producing a double hyphen in the Key Vault name.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- azure
- Domain
- cloud
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100