microsoft / microsoft/azure-devops-go-api

Struct GraphGroup does not export isDeleted property

Open
#43 6 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

question
Dominant language
Go
Stars
223
Forks
92
PR merge metrics
No merged PRs in 30d

Description

While authoring acceptance tests for the Azure DevOps Terraform provider I discovered that type GraphGroup struct does not export the isDeleted property.

image

The acceptance test requires a check if a created group has been removed (deleted) by the destroy operation of Terraform. The issue is that a call to GetGroup of the Graph client the group is still returned so the acceptance test still assumes that the group was not destroyed and thus consequently fails. If the isDeleted property would be available in the struct, the implementation can check the state of the property to verify a successful destruction aside that the GetGroup method returns nil.

@nmiodice

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Go definition of GraphGroup and the GetGroup response path in the Azure DevOps Graph client. Compare the API response with the struct and the acceptance-test behavior; done means the deletion state can be checked after Terraform destroy even when GetGroup still returns the group.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.