microsoft / microsoft/azure-devops-go-api

Variables parsing in VariableGroup

Open
#186 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
223
Forks
92
PR merge metrics
No merged PRs in 30d

Description

Currently this is how variables in VariableGroup are parsed

type VariableGroup struct {
        .....
	// Gets or sets variables contained in the variable group.
	Variables **map[string]interface{} `json:"variables,omitempty"`
}

In order to get the value of a specific variable, we need to some type assertion:

for key, variable := range *variableGroup.Variables {
		value := variable.(map[string]interface{})["value"]
		log.Printf("Variable Name: %v, Value: %v", key, value)
}

Could we not do this instead?

type VariableGroup struct {
        .....
	// Gets or sets variables contained in the variable group.
	Variables *map[string]map[string]interface{} `json:"variables,omitempty"`
}

Therefore we could get the value, this way:

for key, variable := range *variableGroup.Variables {
		vari := variable["value"]
		log.Printf("Variable Name: %v, Value: %v", key, vari)
}

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the VariableGroup definition and inspecting its current Variables type and usages. Compare the proposed nested map type with the JSON shape and existing consumers, then verify that variable access still works across the relevant API models and tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.