microsoft / microsoft/azure-devops-go-api

[Feature Request] Include pipeline data in Approval object in v7 pipeline approvals

Open
#147 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
223
Forks
92
PR merge metrics
No merged PRs in 30d

Description

The Approval object in v7/pipelineapprovals doesn't seem to match the actual REST response type.

{
    "id": "16741a55-948b-4194-8c63-1637ca311a46",
    "steps": [],
    "status": "pending",
    "createdOn": "2024-01-01T07:00:14.127Z",
    "lastModifiedOn": "2024-01-01T07:00:14.1267785Z",
    "executionOrder": "anyOrder",
    "minRequiredApprovers": 1,
    "blockedApprovers": [],
    "_links": {
        "self": {
            "href": "AN_HREF_HERE" 
        }
    },
    "pipeline": {
        "owner": {
            "_links": {
                "web": {
                    "href": A_LINK_TO_THE_BUILD_HERE
                },
                "self": {
                    "href": "<REDACTED>
                }
            },
            "id": 149350,
            "name": "<REDACTED>"
        },
        "id": "413",
        "name": "Retag Images"
    }
}

The Go type in the SDK doesn't include the corresponding pipeline type and it would be really nice if it was included to simplify making additional REST calls to get the actual data.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Go Approval type in the v7/pipelineapprovals entry point and compare it with the REST response example, focusing on the omitted pipeline data. Trace the related type definitions and package tests, if present, and confirm the Approval value exposes the returned pipeline fields.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.