microsoft / microsoft/automatic-graph-layout
Test Failure: NestedDeepTranslationTest
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 1.5k
- Forks
- 319
- Avg merge
- 38m
- Merged PRs (30d)
- 1
Description
This test fails for a couple of different reasons:
- nodes[0] and nodes[1] aren't part of any cluster hierarchy that contains
CreateCluster(nodes.Take(2), 10) - Clusters is a subtype of Node, but not all created clusters are added to the graph. I think they need to be right?
- The assertion loop fails on nodes[0], nodes[1], and the edge from inside the translated cluster hierarchy to a node in
CreateCluster(nodes.Take(2), 10)since deep translation usesEdgesIncomingToNodeWithDescendantSource.
Are all of these just problems with the test, or does DeepTranslation need to handle edges that aren't entirely in the cluster hierarchy slightly differently? (i.e. the source/destination of an edge isn't in the cluster hierarchy)
Or, should DeepTranslation even try to translate edge boundning boxes? Should the translated graph just be rerouted by the caller after DeepTranslation?
I don't need DeepTranslation to behave in any particular way myself, but failing tests annoy me. 😄
Thanks,
Bill
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the failing NestedDeepTranslationTest and inspect DeepTranslation, CreateCluster(nodes.Take(2), 10), and EdgesIncomingToNodeWithDescendantSource. Determine whether the test setup or DeepTranslation should handle nodes, clusters, and edges outside the translated hierarchy. Done requires an agreed behavior and a passing test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100