microsoft / microsoft/automatic-graph-layout
NullReferenceException when calling RemoveNode on graph without GeometryGraph
Open
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 1.5k
- Forks
- 319
- Avg merge
- 38m
- Merged PRs (30d)
- 1
Description
The following code will throw a NullReferenceException:
var graph = new Microsoft.Msagl.Drawing.Graph("graph");
var node = new Microsoft.Msagl.Drawing.Node("node");
graph.AddNode(node);
graph.RemoveNode(node);
Because without having displayed the graph https://github.com/microsoft/automatic-graph-layout/blob/ee9232bc292252fe897acb53d85b8ededadae768/GraphLayout/Drawing/Graph.cs#L300
GeometryGraph.Nodes.Remove(node.GeometryObject as Core.Layout.Node);
GeometryGraph is null.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in GraphLayout/Drawing/Graph.cs at the RemoveNode code linked in the issue, and reproduce the minimal C# example without displaying the graph. Add coverage for removing a node before a GeometryGraph exists, then verify the example completes without a NullReferenceException.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 52/100