microsoft / microsoft/automatic-graph-layout
Editing Sample, with Edge insertion crashes in a particular case
Nobody has claimed this yet.
- Dominant language
- C#
- Stars
- 1.5k
- Forks
- 319
- Avg merge
- 38m
- Merged PRs (30d)
- 1
Description
In the Editing sample, I modified the position of the "How It Works" button, so that I could see the "Edge insertion" button.
I clicked on that, selected the "ter1B" node as the starting point, dragged the edge down below the bottom of the "white area" and then to the right. When the new edge was almost touching both "prot_H1-Q1b" and "prot_Q2b-H2" I got a NullReferenceException in:
Routing\InteractiveEdgeRouter.cs
static RelaxedPolylinePoint CreateRelaxedPolylinePoints(Polyline polyline)
"polyline was null"
This happens both maximized and non-maximized (on a 4K monitor if it makes a difference).
Rob
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by running the Editing sample and following the reported Edge insertion steps with the "ter1B" node, dragging the new edge below and then rightward near "prot_H1-Q1b" and "prot_Q2b-H2". Read Routing/InteractiveEdgeRouter.cs, especially CreateRelaxedPolylinePoints(Polyline polyline), and investigate the null polyline reported there. Done means this case no longer raises a NullReferenceException.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- csharp
- Domain
- computer-graphics
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100