a minor bug in datetime encoding
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1k
- Forks
- 174
- PR merge metrics
- No merged PRs in 30d
Description
Hi,
I found a minor bug here:
Here we intend to encode the yearly periodicity. .day of the datetime.datetime object instead returns day of month. ref: Python docs
Proposed change:
ones * np.cos(2 * np.pi * time[b].timetuple().tm_yday / 365.25),
ones * np.sin(2 * np.pi * time[b].timetuple().tm_yday / 365.25),
Thanks!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in aurora/model/encoder.py at lines 237-238 and inspect how the datetime value is used for yearly periodicity. Replace the day-of-month component with the day-of-year value described in the issue, then verify that the encoder represents yearly periodicity correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100