microsoft / microsoft/aspire

`TransportOptionsValidator` doesn't validate properly if AllowUnsecuredTransport=true

Open
#6,515 2 comments 0 reactions 0 assignees View on GitHub
area-app-model
Dominant language
C#
Stars
6.3k
Forks
991
Avg merge
2d 15h
Merged PRs (30d)
196

Description

### Is there an existing issue for this?

- [x] I have searched the existing issues

### Describe the bug

If AllowUsecuredTransport=true then `TransportOptionsValidator` stops validating the address. For example, there is no validation that no value is specified if AllowUsecuredTransport=true.

https://github.com/dotnet/aspire/blob/08dd9928cdf483947fd01d35ea77e8cd5d1294a2/src/Aspire.Hosting/Dashboard/TransportOptionsValidator.cs#L14-L16

### Expected Behavior

AllowUsecuredTransport=true only impacts validating whether the transport is secure or not.

### Steps To Reproduce

_No response_

### Exceptions (if any)

_No response_

### .NET Version info

_No response_

### Anything else?

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.