microsoft / microsoft/aspire

Allow all warnings from Kestrel to be bubbled in the AppHost

Open
#3,262 0 comments 1 reaction 0 assignees View on GitHub
area-app-model
Dominant language
C#
Stars
6.3k
Forks
991
Avg merge
2d 15h
Merged PRs (30d)
196

Description

See the conversation here:

> We suppressed that because we wanted to tightly control what was being output to the console. For example if you raise it to warning you get this in the output:
>
> ![image](https://private-user-images.githubusercontent.com/513398/317225127-c77bb9ad-22fc-4c1d-9b07-42974bb0422e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTE1NTE1NDIsIm5iZiI6MTcxMTU1MTI0MiwicGF0aCI6Ii81MTMzOTgvMzE3MjI1MTI3LWM3N2JiOWFkLTIyZmMtNGMxZC05YjA3LTQyOTc0YmIwNDIyZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwMzI3JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDMyN1QxNDU0MDJaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mMTJjMzFlMzc4OTBkZjE5OTgyNTg4Y2EyZmU4YzdkOTNhNzdlNGY1ZDJmNGZhZDg3MDUyMDQ0MmVkNjc2YmYwJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.Ge9zxcONF4aI-DE1VcvNgRu1fnBggzU9jaVoluuEw7I)

@adityamandaleeka @amcasey @halter73 - would it make sense to have a setting in Kestrel that told it "I did this override intentionally, please don't emit a warning for this?" That way Aspire wouldn't need to suppress all warnings, and then opt back in case-by-case to the warnings it wants to bubble out.

_Originally posted by @eerhardt in https://github.com/dotnet/aspire/issues/2914#issuecomment-2022991797_

We should follow the suggestion of clearing out the `ASPNETCORE_URLS` env var and continue allowing all Kestrel warnings to be bubbled up to the user. See also

* https://github.com/dotnet/aspire/pull/1933
* https://github.com/dotnet/aspire/pull/3212

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.