microsoft / microsoft/aspire

gRPC client doesn't work with Service Discovery scheme resolution syntax

Open
#2,896 21 comments 3 reactions 0 assignees View on GitHub
area-service-discovery
Dominant language
C#
Stars
6.3k
Forks
991
Avg merge
2d 15h
Merged PRs (30d)
196

Description

The format used to support URI scheme resolution recently added to service discovery (e.g. `https+http://`) does not work with the gRPC client stack. The [`GrpcChannel` class](https://github.com/grpc/grpc-dotnet/blob/933023b6f818ec54dfe84e7d31ec50dfe5044c13/src/Grpc.Net.Client/GrpcChannel.cs#L105) does a lot of initialization in its constructor based on the scheme of the address and special-cases `https://` and `http://` for numerous operations including `ResolverFactory` resolution and credential selection.

@JamesNK interested in your thoughts on how we might go about fixing this. I messed about a bit with a custom `ResolverFactory` and got further but seems we'd have to integrate more deeply to make the syntax work or update `GrpcChannel` to tolerate it some other way.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.