microsoft / microsoft/aspire

Nit: misleading phrasing when updating packages

Open Beginner friendly
#19,191 1 comment 0 reactions 0 assignees View on GitHub
area-cli triage:bot-seen
Dominant language
C#
Stars
6.3k
Forks
991
Avg merge
2d 15h
Merged PRs (30d)
196

Description

When using `aspire update --channel daily` to update a 14.6 project to `13.6.0-preview.1.26410.1+9b79ab510c9f171c48e3af1d69ff6a941127f9a5, the output is a bit misleading

The output says `Added` (past tense) as if it has already added the entries to the file, and then at the end asks for permissions at the end. If you decline the update, then the entries are never added.

The phrasing should use the present tense (`Adding`) or an instruction (i.e. `Add`) because the changes are only proposals, and not actually made until you accept them with the final prompt.

```
Perform updates? [Y/n]: y

Which directory for NuGet.config file? (REDACTED): REDACTED

Added: https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet9/nuget/v3/index.json

Mapping: Aspire* (added)

Added: https://api.nuget.org/v3/index.json

Mapping: * (added)

Retained: REDACTED

Mapping: *

Apply these changes to NuGet.config? [Y/n]: n
```

Contributor guide

Open the contributing guide

Research direction

Start at the `aspire update --channel daily` command and trace where the NuGet.config proposal output is formatted, searching for the `Added:` wording. Verify that the displayed wording describes proposed changes before the final permission prompt, including when the user declines, and check the command's existing tests if available.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
cli
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.