microsoft / microsoft/aspire

Harden NativeAOT CLI signing glob

Open
#16,545 1 comment 0 reactions 0 assignees View on GitHub
area-engineering-systems
Dominant language
C#
Stars
6.3k
Forks
991
Avg merge
2d 15h
Merged PRs (30d)
196

Description

Follow-up from NativeAOT dotnet-tool packaging review in #16496.

José flagged that the NativeAOT CLI signing glob is broader than intended and can match intermediate AOT/linker outputs rather than only the binary that actually ships.

Review thread: https://github.com/microsoft/aspire/pull/16496#discussion_r3157783043
Umbrella: #16542

Tasks:

- [ ] Decide whether the standalone NativeAOT CLI `ItemsToSign` entry is still needed now that the native archive payload is signed through container signing.
- [ ] If standalone signing is still needed, scope it to the actual staged shipping binary path rather than broad `Aspire.Cli.*\**\aspire(.exe)` matches.
- [ ] Validate the selected path in an AzDO binlog by confirming the expected `ItemsToSign` entry is present and intermediate native/linker outputs are not included.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.