microsoft / microsoft/aspire

RedisCommander should be child of Redis

Open
#14,050 1 comment 0 reactions 0 assignees View on GitHub
needs-area-label
Dominant language
C#
Stars
6.3k
Forks
991
Avg merge
2d 15h
Merged PRs (30d)
196

Description

### Is there an existing issue for this?

- [x] I have searched the existing issues

### Is your feature request related to a problem? Please describe the problem.

When using `builder.AddRedis().AddRedisCommander()`, a relationship is defined between them. To me, it makes the most sense for the `rediscommander` resource to be a _child_ of the `redis` resource, since it depends on the `redis` resource.

### Describe the solution you'd like

I think the only thing that needs to be changed is the following line:
https://github.com/dotnet/aspire/blob/5d1f4afdea2b42063cd4d8f736f2c5169383d4df/src/Aspire.Hosting.Redis/RedisBuilderExtensions.cs#L291

### Additional context

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.