microsoft / microsoft/aspire

Aspire.Cli.Tests should not reference to Aspire.Hosting and Aspire.Hosting.Testing

Open
#10,443 2 comments 0 reactions 1 assignee Claimed by @mitchdenny View on GitHub
area-cli
Dominant language
C#
Stars
6.3k
Forks
991
Avg merge
2d 15h
Merged PRs (30d)
196

Description

### Is there an existing issue for this?

- [x] I have searched the existing issues

### Describe the bug

Because `Aspire.Cli.Tests` tests project references both `Aspire.Hosting` and `Aspire.Cli`, and `InternalsVisibleTo` is enabled on both to `Aspire.Cli.Tests`, any internal types have conflicts with "Type exists in both XXX and YYY".

This prevents sharing internal code between the two.

### Expected Behavior

I think `Aspire.Hosting` and `Aspire.Hosting.Testing` shouldn't be referenced by `Aspire.Cli.Tests`.

If there are tests that need both then I argue that is an integration test, and should be moved to a new integration tests project, i.e. `Aspire.Cli.IntegrationTests`.

### Steps To Reproduce

_No response_

### Exceptions (if any)

_No response_

### .NET Version info

_No response_

### Anything else?

_No response_

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.