microsoft / microsoft/aspire

DockerComposeInfrastructure should only configure OTLP for resources attached to that environment

Open
#10,093 0 comments 3 reactions 0 assignees View on GitHub
area-app-model
Dominant language
C#
Stars
6.3k
Forks
991
Avg merge
2d 15h
Merged PRs (30d)
196

Description

See this code

https://github.com/dotnet/aspire/blob/223ff6aed4959e88b9f4b4fbc730cb673b2f60b9/src/Aspire.Hosting.Docker/DockerComposeInfrastructure.cs#L54-L71

This is configuring an OTLP endpoint on all compute resources in the AppModel. But if there are multiple compute environments (for example multiple Compose, or one Compose and one K8s), this will configure OTLP env vars on compute resources that don't belong to this environment.

The code should check if the resource belongs to this environment before modifying the env vars.

cc @davidfowl @captainsafia @mitchdenny

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.