microsoft / microsoft/ai-dev-gallery

Searching and adding new Embeddings models

Open
#75 2 comments 0 reactions 1 assignee View on GitHub

@beth-panx is already working on this.

Since Jan 17, 2025.

needs author feedback
Dominant language
C#
Stars
1.5k
Forks
223
PR merge metrics
No merged PRs in 30d

Description

This is somehow related to https://github.com/microsoft/ai-dev-gallery/issues/12 or at least in the same direction with extra flavor.

I tried to add a new embedding model to use in the RAG sample and found the search never returned for some queries.

In some model search queries, the async Task SearchModels never ends because there is no actionBlock.Complete() when models search results don't have genai_config.json. The code doesn't check whether this is the scenario, so no actionBlock.complete().

These are the lines that make the search asyn never completing:

var configs = result.Siblings.Where(r => r.RFilename.EndsWith("genai_config.json", StringComparison.InvariantCultureIgnoreCase));
.....
if (!configs.Any())
{
continue;
}

Even adding a flag to control whether the async needs to complete, something like:

if (!flag)
{
actionBlock.Complete();
}

the ultimate result is that the embedding model is never returned.
I wanted to add new embedding models, and I can't simply find a suitable one because of this missing genai_config.json.

Looking af model files in hugging face, this file is not there for sentence-transformers

So it seems the search is not prepared to find embeddings and add them to the gallery. Am I assessing this correctly? Is this an issue, or perhaps I am missing something?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.