microsoft / microsoft/agent-framework

.NET: LocalVariable Naming Convention in LocalEvaluation

Open
#6,532 0 comments 0 reactions 1 assignee View on GitHub

@alliscode is already working on this.

Since Jun 16, 2026.

.NET
Dominant language
Python
Stars
13.6k
Forks
2.3k
Avg merge
2d 45m
Merged PRs (30d)
358

Description

## Summary
Correct the naming conventions of local variables in the `src/Evaluation/LocalEvalutation.cs` file to conform to the C# naming standards.

## Code
in `src/Evaluation/LocalEvalutation.cs`

```C#
public Task EvaluateAsync(
IReadOnlyList items,
string evalName = "Local Eval",
CancellationToken cancellationToken = default)
{
var results = new List(items.Count);

foreach (var item in items)
{
cancellationToken.ThrowIfCancellationRequested();

var evalResult = new EvaluationResult();

foreach (var check in this._checks)
{
// EvalCheckResult -> evalCheckResult
var evalCheckResult = check(item);
evalResult.Metrics[evalCheckResult.CheckName] = new BooleanMetric(
evalCheckResult.CheckName,
evalCheckResult.Passed,
reason: evalCheckResult.Reason)
{
Interpretation = new EvaluationMetricInterpretation
{
Rating = evalCheckResult.Passed
? EvaluationRating.Good
: EvaluationRating.Unacceptable,
Failed = !evalCheckResult.Passed,
},
};
}

results.Add(evalResult);
}

return Task.FromResult(new AgentEvaluationResults(this.Name, results, inputItems: items));
}
```

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.