microsoft / microsoft/agent-framework
.NET: Incorrect description on AgentSessionStore.GetSessionAsync regarding "returning null if not found"
Open
@chetantoshniwal is already working on this.
Since May 28, 2026.
.NET
- Dominant language
- Python
- Stars
- 13.6k
- Forks
- 2.3k
- Avg merge
- 2d 45m
- Merged PRs (30d)
- 358
Description
https://github.com/microsoft/agent-framework/blob/b2e77067e920165d076ffdaa7ddc7d289890a9c1/dotnet/src/Microsoft.Agents.AI.Hosting/AgentSessionStore.cs#L39-L45
Judging by 1) existing implementations (noop session store, in memory session store), 2) use by AIHostAgent, 3) and the nullability contract, the description should say that a new session must be returned if not found, and that `null` should _not_ be returned.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.