microsoft / microsoft/XPretrain
About LF-VILA code in PatchEmbed3D of video encoder
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 511
- Forks
- 35
- PR merge metrics
- No merged PRs in 30d
Description
the padding seems not right, or maybe i made a mistake
# padding
_, _, D, H, W = x.size()
if H % self.patch_size[0] != 0:
x = F.pad(x, (0, 0, 0, self.patch_size[1] - H % self.patch_size[1]))
if W % self.patch_size[1] != 0:
x = F.pad(x, (0, 0, 0, 0, 0, self.patch_size[0] - D % self.patch_size[0]))
owing to patch_size=[1, 8, 8] where 8x8 is HxW in implementation, should it be padded in H and W dimension?
condition H % self.patch_size[0] != 0 and W % self.patch_size[1] != 0 make me lost
thanks a lot!
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the PatchEmbed3D implementation in the video encoder and compare the tensor dimension order with patch_size=[1, 8, 8] and the shown F.pad calls. Done means determining whether the H/W conditions and padding axes are correct, then documenting or fixing the mismatch if confirmed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- computer-vision
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100