microsoft / microsoft/WindowsAppSDK
PushNotificationManager SelfContained scenarios need better error code
Open
@pmpurifoy is already working on this.
Since Apr 18, 2022.
area-Notifications
documentation
feature proposal
good first issue
Status: In PR
- Dominant language
- C++
- Stars
- 4.7k
- Forks
- 471
- Avg merge
- 3d 13h
- Merged PRs (30d)
- 28
Description
Describe the bug
Currently, the PushNotificationManager APIs return E_FAIL if SelfContained scenario is not supported. A better HRESULT to use would be HRESULT_FROM_WIN32(ERROR_NOT_SUPPORTED).
From this conversation:
https://github.com/microsoft/WindowsAppSDK/pull/2389#discussion_r851574133
Steps to reproduce the bug
In unpackaged/SelfContained environment, call into PushNotificationManager APIs and view the returned error code.
Expected behavior
No response
Screenshots
No response
NuGet package version
No response
Packaging type
No response
Windows version
No response
IDE
No response
Additional context
No response
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.