microsoft / microsoft/WindowsAppSDK

Add cleanup to AppNotificationManager::Register

Open
#2,269 0 comments 0 reactions 1 assignee View on GitHub

@pmpurifoy is already working on this.

Since Mar 15, 2022.

area-Notifications feature proposal good first issue Status: In PR
Dominant language
C++
Stars
4.7k
Forks
471
Avg merge
3d 13h
Merged PRs (30d)
28

Description

Need to add scope_exit after these registrations to remove them in the case of subsequent failure.

Originally posted by @hulumane in https://github.com/microsoft/WindowsAppSDK/pull/2267#discussion_r827388952

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.