microsoft / microsoft/WindowsAppSDK-Samples

Samples use EOL'd TargetFrameworks

Open
#547 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
PowerShell
Stars
1k
Forks
335
Avg merge
5d 1h
Merged PRs (30d)
8

Description

Many samples use the "net6.0" TargetFramework moniker, but - as per the .Net and .Net Core Official Support Policy - .net6.0 fell out of support on November 12, 2024. If I attempt to build those samples with a supported dotnet sdk, I get build errors:

"S:\source\github\microsoft\WindowsAppSDK-Samples\samples\Input\cs-winui\Input.sln" (default target) (1) ->
"S:\source\github\microsoft\WindowsAppSDK-Samples\samples\Input\cs-winui\Input.csproj" (default target) (2) ->
(_CheckForEolTargetFrameworks target) ->
  C:\Program Files\dotnet\sdk\9.0.305\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.EolTargetFrameworks.targets(32,5): e
rror NETSDK1138: The target framework 'net6.0-windows10.0.19041.0' is out of support and will not receive security upda
tes in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the support policy. [S
:\source\github\microsoft\WindowsAppSDK-Samples\samples\Input\cs-winui\Input.csproj]

Moving to net8.0 (which is the latest LTS release) doesn't seem unreasonable..?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by searching the sample projects for TargetFramework entries using net6.0, including samples/Input/cs-winui/Input.csproj, and inspect the related Input.sln. Update the affected frameworks to the supported target identified in the issue, then build the samples with a supported .NET SDK and confirm NETSDK1138 no longer occurs.

Written by the indexing model from the issue text.

Assessment

Tech stack
csharp
Domain
build-system
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.