Crash in XamlBind sample when canceling 'Change Folder...' dialog

Open

#1,117 opened on Jun 27, 2019 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 2/5
Estimated time: 1-3 hours
Newbie friendliness: 45/100

Issue type: Bug
Clarity: Clearly specified
Activity status: Stale
Tech stack: cpp, csharp
Domain: desktop

Research direction

Start with Samples/XamlBind/cs/xBindSampleModel/FileSystemDataSource.cs at SetupDataSourceImpl() and Samples/XamlBind/cpp/PhasingTests.xaml.cpp at PhasingTests::ChangeFolderClick(). Reproduce the crash by canceling the Change Folder dialog, then verify the sample no longer dereferences the canceled folder and the List phasing using x:Phase tab remains usable.

Written by the indexing model from the issue text.

Description

FileDataSource::SetupDataSourceImpl() will dereference NULL on the 'List phasing using x:Phase' tab after choosing 'Cancel' from the 'Change Folder...' dialog.
https://github.com/microsoft/Windows-universal-samples/blob/cdfd8ef6b38a710eb5e85c776a48c8369b4c74de/Samples/XamlBind/cs/xBindSampleModel/FileSystemDataSource.cs#L112

This occurs since there is no NULL checking of 'f' when handling picker->PickSingleFolderAsync() in PhasingTests::ChangeFolderClick()
https://github.com/microsoft/Windows-universal-samples/blob/cdfd8ef6b38a710eb5e85c776a48c8369b4c74de/Samples/XamlBind/cpp/PhasingTests.xaml.cpp#L61

Dominant language: JavaScript
Stars: 9.7k
Forks: 7.8k
PR merge metrics: No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Similar issues

[Duplicate Code] Repeated filtered model-alias assembly in proxy server Open

code-quality refactoring

Difficulty 2/5 1-3 hours Newbie friendliness 84/100

github/gh-aw-firewall#8816 · Opened Sep 20, 2026
quickjs: support `timeout=None` (no per-call deadline) in `CodeInterpreterMiddleware` Open

integration:quickjs org:external priority:backlog topic:code-interpreter topic:middleware type:feature

Difficulty 2/5 1-3 hours Newbie friendliness 74/100

langchain-ai/deepagents#6450 · Opened Sep 20, 2026
[optimization:agents-md-curator] AGENTS.md: compress duplicated Debugging & Logging section and merge redundant autopilot rules Open

optimization optimization:agents-md-curator

Difficulty 2/5 1-3 hours Newbie friendliness 86/100

githubnext/gh-aw-cao#13143 · Opened Sep 20, 2026
[BUG] schema-compat/zodToJsonSchema: nullable zod v4 enum/literal widens to type:[X,"null"] but keeps enum/const, so exported schema rejects null Open

status: needs triage

Difficulty 2/5 1-3 hours Newbie friendliness 88/100

mastra-ai/mastra#24516 · 2 comments · Opened Sep 20, 2026
Kubernetes request flow diagram 404s on both copies of the tutorial Open

Difficulty 2/5 1-3 hours Newbie friendliness 88/100

layer5io/docs#1263 · Opened Sep 20, 2026

More JavaScript issues