microsoft / microsoft/Windows-driver-samples
Change MiniFilter: Is the PreCreate operation comment correct?
@jrixie is already working on this.
Since Apr 28, 2026.
- Dominant language
- C
- Stars
- 7.8k
- Forks
- 5k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 7
Description
Is the following comment in the example Change MiniFilter CgPreCreate method correct?
//
// Return FLT_PREOP_SYNCHRONIZE at PreCreate due to
// some callback of PostCreate may be at DPC level.
// eResource is required at level < DPC.
//
The Microsoft documentation mentions that PostCreate will always be called at PASSIVE_LEVEL - ref.
Also, the Microsoft documentation specifically for FLT_PREOP_SYNCHRONIZE states that PreCreate shouldn't return FLT_PREOP_SYNCHRONIZE, as Create operations are already synchronized - ref.
I see a comment on this method in the past, but it looks to be targeting a different comment - Issue 151.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.