microsoft / microsoft/Windows-classic-samples
Wrong Implementation of GetBackgroundColor in WicAnimatedGif
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 5.7k
- Forks
- 3.3k
- PR merge metrics
- No merged PRs in 30d
Description
/grctlext/TransparentColorIndex should be used to check if it's transparent instead of dwBGColor >> 24
Fixed version:
Without fix:
GIF from: https://en.tankiwiki.com/images/en/3/33/Preview_Disco_2.0.gif both in the browser and irfanview it shows as having a transparent BG
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in Samples/Win7Samples/multimedia/wic/wicanimatedgif/WicAnimatedGif.cpp at line 915 and inspect how GetBackgroundColor handles the GIF background. Use the Graphic Control Extension's TransparentColorIndex as described, then verify that the supplied Disco 2.0 GIF renders with a transparent background rather than an opaque one.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- computer-graphics, desktop
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100