microsoft / microsoft/Windows-classic-samples
RegfsProvider fails displaying HKEY_CURRENT_USER because of the * entry
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 5.7k
- Forks
- 3.3k
- PR merge metrics
- No merged PRs in 30d
Description
In RegfsProvider::PopulateDirInfoForPath the _regOps.EnumerateKey does not seem to perform any filtering on the keys is fetches, so if it encounters a key containing characters invalid for the Windows File System, PrjFillDirEntryBuffer will refuse the entry and the enumeration of the directory will abort
A possible fix is to have EnumerateKey only perform the entries.SubKeys.push_back(entry); if the keyName has passed some sanity check.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in Samples/ProjectedFileSystem/regfsProvider.cpp at RegfsProvider::PopulateDirInfoForPath, then inspect EnumerateKey and entries.SubKeys.push_back in regOps.h. Reproduce enumeration of HKEY_CURRENT_USER and observe how PrjFillDirEntryBuffer handles the * entry. Done means invalid key names are excluded and directory enumeration completes successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100