microsoft / microsoft/Windows-classic-samples
[Win7Sample.OleDb.RowsetViewer] SafeArrayToString does not append wEOL symbol.
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 5.7k
- Forks
- 3.3k
- PR merge metrics
- No merged PRs in 30d
Description
When I was using the debug build of RowsetViewer I noticed that it displayed the strange data of Array column:
As I understand, SafeArrayToString must append wEOL symbol in result string but does not do it:
This function is called from here:
https://github.com/microsoft/Windows-classic-samples/blob/7cbd99ac1d2b4a0beffbaba29ea63d024ceff700/Samples/Win7Samples/dataaccess/oledb/rowsetviewer/common.cpp#L563-L571
If SafeArrayToString adds wEOL symbol in the result string, it works well:
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect SafeArrayToString in Samples/Win7Samples/dataaccess/oledb/rowsetviewer/common.cpp around line 1051, then follow its caller around lines 563-571. Reproduce the reported array-column display in the RowsetViewer debug build and verify that the resulting output includes the requested line-ending behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- database, desktop
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100