microsoft / microsoft/Windows-classic-samples
Bug with COM DLL reference counting - Credential Provider and a few other samples
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 5.7k
- Forks
- 3.3k
- PR merge metrics
- No merged PRs in 30d
Description
No dll reference counting is in done in the constructor:
https://github.com/microsoft/Windows-classic-samples/blob/7cbd99ac1d2b4a0beffbaba29ea63d024ceff700/Samples/CredentialProvider/cpp/Dll.cpp#L25-L27
Whereas in other samples:
https://github.com/microsoft/Windows-classic-samples/blob/7cbd99ac1d2b4a0beffbaba29ea63d024ceff700/Samples/Win7Samples/winbase/DeviceFoundation/FunctionDiscovery/Provider/FDProviderSample/ComServer.cpp#L71-L75
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the constructor implementations in Samples/CredentialProvider/cpp/Dll.cpp, Samples/IME/cpp/SampleIME/Server.cpp, and Samples/Win7Samples/winui/input/tsf/textservice/propertytextservice/Server.cpp. Compare them with the linked FunctionDiscovery, WindowsSearch, and avscamera examples to understand the reference-counting pattern. Done means the affected samples consistently handle DLL reference counting and their relevant behavior has been checked.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- desktop, operating-systems
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100