microsoft / microsoft/Windows-classic-samples

SampleHardwareEventCredentialProvider is not to free resources

Open
#246 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
No language data
Stars
5.7k
Forks
3.3k
PR merge metrics
No merged PRs in 30d

Description

I am exploring windows credential providers.
So, I have started with this samples SampleHardwareEventCredentialProvider from https://github.com/Microsoft/Windows-classic-samples/tree/master/Samples/Win7Samples/security/credentialproviders solution.

I added some logs to constructors and destructors for the following classes:
CSampleCredential, CommandWindow, CSampleProvider, MessageCredential.

Seems, that destructors are not called after login.

Build environment
Windows 10 - 64 bit
Visual Studio 2019

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the SampleHardwareEventCredentialProvider solution and inspect the lifetimes of CSampleCredential, CommandWindow, CSampleProvider, and MessageCredential, including their destructors. Reproduce the login flow on Windows 10 with the added logs and determine whether the missing destructor calls indicate a resource leak or an expected credential-provider lifecycle; document the finding or identify the needed cleanup change.

Written by the indexing model from the issue text.

Assessment

Domain
authentication
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.