microsoft / microsoft/Windows-classic-samples
Typo on source code?
Open
Nobody has claimed this yet.
- Dominant language
- No language data
- Stars
- 5.7k
- Forks
- 3.3k
- PR merge metrics
- No merged PRs in 30d
Description
Shouldn't i be replaced with retval instead?
We shall check the return value of select against SOCKET_ERROR as also documented here: https://docs.microsoft.com/en-us/windows/win32/api/winsock2/nf-winsock2-select
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open Samples/Win7Samples/netds/winsock/simple/ioctl/Simples_Ioctl.cpp at line 293 and inspect how the select return value is checked. Compare the check with the Winsock select documentation linked in the issue. Done means the sample checks the correct return-value variable against SOCKET_ERROR and still builds successfully.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 58/100