microsoft / microsoft/Windows-Driver-Developer-Supplemental-Tools

Storport entry points not handled correctly

Open
#194 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
CodeQL
Stars
85
Forks
38
PR merge metrics
No merged PRs in 30d

Description

I have a Storport driver that uses sp_DRIVER_INITIALIZE as the entry point which is in StorportDrivers.qll, but I get the following failure when I run recommended.qls on my driver code:

<AssessmentScore ScoreName="smartpqi.x64.Semmle.Defect.cpp/drivers/current-function-type-not-correct" ScoreValue="1" ScoreUnit="SEMMLE_RECOMMENDED_FAILED" />

How do I get this corrected?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting StorportDrivers.qll for handling of sp_DRIVER_INITIALIZE and then run recommended.qls against the reported driver. Confirm the correction by rerunning the assessment and verifying that current-function-type-not-correct is no longer reported.

Written by the indexing model from the issue text.

Assessment

Domain
operating-systems
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.