microsoft / microsoft/Windows-Containers
`install-docker-ce.ps1` should install the Windows feature `Microsoft-Hyper-V`, not the non-existent Windows feature `Hyper-V`
Nobody has claimed this yet.
- Dominant language
- PowerShell
- Stars
- 551
- Forks
- 76
- PR merge metrics
- No merged PRs in 30d
Description
Is your feature request related to a problem? Please describe.
A clear and concise description of what the problem is. Ex. I'm always frustrated when [...]
Describe the solution you'd like
A clear and concise description of what you want to happen.
install-docker-ce.ps1should install the Windows featureMicrosoft-Hyper-V, not the non-existent Windows featureHyper-V. See https://github.com/microsoft/Windows-Containers/blob/6ace4f158e85674df5a246f7173ecf1109234d74/helpful_tools/Install-DockerCE/install-docker-ce.ps1#L306- Currently, if the following command is executed only in PowerShell 7,
Invoke-WebRequest -UseBasicParsing "https://raw.githubusercontent.com/microsoft/Windows-Containers/Main/helpful_tools/Install-DockerCE/install-docker-ce.ps1" -OutFile ./install-docker-ce.ps1
./install-docker-ce.ps1
docker run hello-world:nanoserver
- This will result in the following error log:
PS C:\Users\lingh> docker run hello-world:nanoserver
Unable to find image 'hello-world:nanoserver' locally
nanoserver: Pulling from library/hello-world
77321bd03612: Pull complete
b282ab27bbb7: Pull complete
dce32bbed4f4: Pull complete
Digest: sha256:17db24031879dda57a6541b9d3db5dc16ddf3e03145ccfd0e0c30855bac658ea
Status: Downloaded newer image for hello-world:nanoserver
docker: Error response from daemon: hcs::CreateComputeSystem 665b048b75a12cef971348db7820758490a4e076b3647c64bee0791e53ff5727: The request is not supported.
Run 'docker run --help' for more information
- This means users always need to additionally execute
Enable-WindowsOptionalFeature -Online -FeatureName Microsoft-Hyper-V -All.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
- Null.
Additional context
Add any other context or screenshots about the feature request here.
- Early investigations can be found at https://www.yuque.com/linghengqian/meve2v/tlc6v3wg2gks3ug3 .
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect helpful_tools/Install-DockerCE/install-docker-ce.ps1 around line 306 and compare the Windows feature name used there with the issue's PowerShell command. Verify the installation flow in PowerShell 7, then run docker run hello-world:nanoserver; done means the script enables the required feature and the container starts without the reported error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- docker, powershell
- Domain
- devops, operating-systems
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 68/100